Skip to content

Detect Spin(7,q) in Omega+(8,q) by its 4-form for q=3 and q=5, to make naming faster - #564

Open
fingolfin wants to merge 1 commit into
mh/TestNaming-improvefrom
mh-ai/omega8-naming
Open

fingolfin wants to merge 1 commit into
mh/TestNaming-improvefrom
mh-ai/omega8-naming

Conversation

@fingolfin

Copy link
Copy Markdown
Member

For d = 8, q = 3, 5, NonGenericOrthogonalPlus separated Omega+(8,q) and its overgroups from Spin(7,q) in its spin representation by a stabiliser chain of the projective action (RECOG.EstimateProjOrder). This is comparatively slow.

Once elements of orders 7, 13 (and 31 for q = 5) are seen, only the maximal subgroups of order |SO(7,q)| remain [Kle87, Table I], so an irreducible group not containing Omega+(8,q) normalises Spin(7,q). That normaliser fixes the line of the Cayley 4-form, acting on it by the squared multiplier, while Omega+(8,q) fixes no line of 4-forms. RECOG.FixesFourFormLine checks this with a 70-dimensional nullspace per generator. The order-312 shortcut for q = 5, a raw element order, goes.

For q = 5, the 13 in [NP99, Table 4] stands for a splitting lppd(8,5;4)-element, so the comment calling the paper wrong is replaced.

Before:

gap> for i in [1..20] do RecogniseClassical(Omega(+1, 8, 3));; od; time/20.;
44.04
gap> for i in [1..20] do RecogniseClassical(Omega(+1, 8, 5));; od; time/20.;
218.35

After:

gap> for i in [1..20] do RecogniseClassical(Omega(+1, 8, 3));; od; time/20.;
10.59
gap> for i in [1..20] do RecogniseClassical(Omega(+1, 8, 5));; od; time/20.;
17.75

Assisted-by: Generative AI

For d = 8, q = 3, 5, NonGenericOrthogonalPlus separated Omega+(8,q)
and its overgroups from Spin(7,q) in its spin representation by a
stabiliser chain of the projective action (RECOG.EstimateProjOrder).

Once elements of orders 7, 13 (and 31 for q = 5) are seen, only the
maximal subgroups of order |SO(7,q)| remain [Kle87, Table I], so an
irreducible group not containing Omega+(8,q) normalises Spin(7,q).
That normaliser fixes the line of the Cayley 4-form, acting on it by
the squared multiplier, while Omega+(8,q) fixes no line of 4-forms.
RECOG.FixesFourFormLine checks this with a 70-dimensional nullspace per
generator. The order-312 shortcut for q = 5, a raw element order, goes.

For q = 5, the 13 in [NP99, Table 4] stands for a splitting
lppd(8,5;4)-element, so the comment calling the paper wrong is replaced.

New tests: GO and Omega(+1,8,5), CGO^+(8,q) and Omega^+(8,q) with
scalars, and the maximal subgroups of order |SO(7,q)| of Omega+(8,q)
for q = 3, 5, via a filter argument for TestNamingMaximals.

Setup, GAP 4.16.1, old code loaded:

    gap> MsPerCall := function(G, n) local t, i; t := NanosecondsSinceEpoch(); for i in [1 .. n] do RecogniseClassical(G); od; return Float((NanosecondsSinceEpoch() - t) / n / 10^6); end;;
    gap> G3 := Omega(+1, 8, 3);; G5 := Omega(+1, 8, 5);;

Before:

    gap> MsPerCall(G3, 50);
    44.0381
    gap> MsPerCall(G5, 50);
    218.351

After, same session, swap.g rebinding the new helper and method:

    gap> Read("swap.g");
    gap> MsPerCall(G3, 50);
    10.591
    gap> MsPerCall(G5, 50);
    17.7594

Assisted-by: Generative AI
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.62%. Comparing base (67807b8) to head (a2b4319).

Files with missing lines Patch % Lines
gap/matrix/classical.gi 98.27% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           mh/TestNaming-improve     #564      +/-   ##
=========================================================
+ Coverage                  86.37%   86.62%   +0.24%     
=========================================================
  Files                         49       49              
  Lines                      19404    19427      +23     
=========================================================
+ Hits                       16760    16828      +68     
+ Misses                      2644     2599      -45     
Files with missing lines Coverage Δ
gap/matrix/classical.gi 87.08% <98.27%> (+0.28%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant